mcvsubbu commented on a change in pull request #4193: Creation/deletion flow
for replica groups sets in realtime
URL: https://github.com/apache/incubator-pinot/pull/4193#discussion_r284055619
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -1113,7 +1113,11 @@ public void addTable(@Nonnull TableConfig tableConfig)
ZKMetadataProvider.setRealtimeTableConfig(_propertyStore,
tableNameWithType, tableConfig.toZNRecord());
// Update replica group partition assignment to the property store if
applicable
- updateReplicaGroupPartitionAssignment(tableConfig);
+ IndexingConfig indexingConfig = tableConfig.getIndexingConfig();
+ StreamConfig streamConfig = new
StreamConfig(indexingConfig.getStreamConfigs());
+ if (streamConfig.hasLowLevelConsumerType() &&
!streamConfig.hasHighLevelConsumerType()) {
Review comment:
So, while migrating we cannot use replica based segment assignment? Not sure
why, but it is good to add some comments here as to why this check is being
made.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
