Jackie-Jiang commented on a change in pull request #4218: Add
RealtimeConsumptionCatchupServiceCallback
URL: https://github.com/apache/incubator-pinot/pull/4218#discussion_r285779496
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
##########
@@ -174,6 +174,8 @@ public ServerType getServerType() {
public static final String CONFIG_OF_STARTER_ENABLE_SEGMENTS_LOADING_CHECK
=
"pinot.server.starter.enableSegmentsLoadingCheck";
public static final String CONFIG_OF_STARTER_TIMEOUT_IN_SECONDS =
"pinot.server.starter.timeoutInSeconds";
+ public static final String
CONFIG_OF_STARTER_REALTIME_CONSUMPTION_CATCHUP_WAIT_TIME_SECONDS =
Review comment:
I would put this along with the
**CONFIG_OF_SERVER_MIN_RESOURCE_PERCENT_FOR_START** since both of them are for
the status check instead of the starter. Maybe rename it to
"pinot.server.startup.realtimeConsumptionCatchupTimeMs"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
