mayankshriv commented on a change in pull request #4243: Add support for
passing headers in pinot client
URL: https://github.com/apache/incubator-pinot/pull/4243#discussion_r288616010
##########
File path:
pinot-api/src/main/java/org/apache/pinot/client/PinotClientTransportFactory.java
##########
@@ -18,9 +18,11 @@
*/
package org.apache.pinot.client;
+import java.util.Map;
+
/**
* Factory for client transports.
*/
interface PinotClientTransportFactory {
- PinotClientTransport buildTransport();
+ PinotClientTransport buildTransport(Map<String, String> headers);
Review comment:
This is an interface change and can potentially impact other users of this
module. Please follow Pinot guidelines for public interface changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
