sunithabeeram commented on a change in pull request #4243: Add support for
passing headers in pinot client
URL: https://github.com/apache/incubator-pinot/pull/4243#discussion_r288641571
##########
File path:
pinot-api/src/main/java/org/apache/pinot/client/PinotClientTransportFactory.java
##########
@@ -18,9 +18,11 @@
*/
package org.apache.pinot.client;
+import java.util.Map;
+
/**
* Factory for client transports.
*/
interface PinotClientTransportFactory {
- PinotClientTransport buildTransport();
+ PinotClientTransport buildTransport(Map<String, String> headers);
Review comment:
+1
It looks like this can be extended by others and this signature change will
break compatibility. This interface should have been marked as public:stable.
We recently add annotations for a few foundation classes, we'll need to do the
same here.
@jitendratheta, if you can review the guidelines here:
https://github.com/apache/incubator-pinot/blob/master/pinot-common/src/main/java/org/apache/pinot/annotations
that will be great. Javadocs for InterfaceStability.java provide more specific
info. As noted there, to keep compatibility, the best option is to provide a
default implementation for the new method while keeping or marking the old one
as deprecated.
We'll look into making one more pass at updating interface annotations, but
for now, it looks like this class should have Audience.Public and
Stability.Stable annotations. Could you add the same?
@mcvsubbu, @Jackie-Jiang - FYI. Please chime in as appropriate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
