mcvsubbu commented on issue #4252: pinot_kafka_0.9.0.1 module URL: https://github.com/apache/incubator-pinot/pull/4252#issuecomment-497013608 > > > > > What is the plan on the naming for the module for different Kafka version implementation? I think that we should keep one implementation for each major version (e.g. `0.9.x`, `1.0.x`,`2.0.x`...) instead of having each module for each specific Kafka version. > > > > > > > > > > > > In principle yes, but are there guarantees that kafka does not change the api within these smaller releases? I am not sure. > > > > > > > > > I would still prefer to keep one package per major version. If we need to bump up the minor version and kafka is not backward compatible, we can change our code to use new api. I don't like the approach of creating module for each version. > > > For example, let's say that we want to bump up the version from 2.1.1 to 2.1.2 and they are backward compatible (or not). Are we going to create another module for `2.1.2` and copy more or less the same code? or are we going to change the package module name? > > > > > > Each time they change API, we create a new version. If they never change API starting 2.1, we are good forever. How does that sound? > > I see. As long as we don't add too many modules and have a clear guideline, I'm fine with it. I just thought that associating a specific version number to the module name is not the flexible approach if we want to bump up Kafka versions frequently. Thanks for the quick comment! When the new kafka module is added (hopefully by @ananthdurai ) we will have a README in the new dir saying that attempts should be made to bump kafka revisions as needed until kafka interface changes. We can even name the directory as kafka-2.1-or-higher.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
