mcvsubbu commented on issue #4252: pinot_kafka_0.9.0.1 module URL: https://github.com/apache/incubator-pinot/pull/4252#issuecomment-497539277 > @mcvsubbu `kafka-1.0` module will import `1.0.x` library. It may work with `kafka-2.0` if there is no API change but we don't guarantee it. For explicit 2.0 support, we can create another module `kafka-2.0` that imports `2.0.x` and we can guarantee that it will work with kafka 2.0. > > @npawar I vote +1 for following flink's approach to organize our modules. It's very clean. I also vote for `pinot-kafka-0.9` instead of `pinot-kafka-0.9.x`. In other words, you are suggesting that we copy over all files even if nothing changes, and keep doing this for every (major) kafka release.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
