jihaozh commented on a change in pull request #4246: [TE] Cube algorithm for
ratio metrics
URL: https://github.com/apache/incubator-pinot/pull/4246#discussion_r288764666
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/cube/cost/OeRatioCostFunction.java
##########
@@ -0,0 +1,103 @@
+package org.apache.pinot.thirdeye.cube.cost;
+
+import com.google.common.base.Preconditions;
+import com.google.common.math.DoubleMath;
+import java.util.Map;
+import org.apache.pinot.thirdeye.cube.data.cube.CubeUtils;
+
+
+public class OeRatioCostFunction implements CostFunction {
Review comment:
Could you add some documents for this class? Is this cost function works for
all ratio metrics or it only works for OE ratio?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
