jihaozh commented on a change in pull request #4246: [TE] Cube algorithm for
ratio metrics
URL: https://github.com/apache/incubator-pinot/pull/4246#discussion_r288763065
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/cube/summary/Summary.java
##########
@@ -408,10 +407,10 @@ public OneSideErrorRowInserter(RowInserter
basicRowInserter, boolean side) {
public void insertRowToDPArray(DPArray dp, CubeNode node, double
targetRatio) {
// If the row has the same change trend with the top row, then it is
inserted.
if ( side == node.side() ) {
- // When do oneSide, we try to make the root's changeRatio close to 1
in order to see the major root causes.
- if ( (side && Double.compare(targetRatio, 1d) > 0) || (!side &&
Double.compare(targetRatio, 1d) < 0)) {
- targetRatio = 1d;
- }
+// // When do oneSide, we try to make the root's changeRatio close to 1
in order to see the major root causes.
+// if ( (side && Double.compare(targetRatio, 1d) > 0) || (!side &&
Double.compare(targetRatio, 1d) < 0)) {
+// targetRatio = 1d;
Review comment:
remove the commented code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
