sunithabeeram commented on a change in pull request #4243: Add support for
passing headers in pinot client
URL: https://github.com/apache/incubator-pinot/pull/4243#discussion_r289208037
##########
File path:
pinot-api/src/main/java/org/apache/pinot/client/PinotClientTransportFactory.java
##########
@@ -18,9 +18,11 @@
*/
package org.apache.pinot.client;
+import java.util.Map;
+
/**
* Factory for client transports.
*/
interface PinotClientTransportFactory {
- PinotClientTransport buildTransport();
+ PinotClientTransport buildTransport(Map<String, String> headers);
Review comment:
@kishoreg it looks like the current ConnectionFactory is tied to JsonHttp
transport. How would things work if Https has to be supported? It appears to me
that the transport factory itself needs to be injected to ConnectionFactory
class in that case.
The class has been marked as evolving. Is it because you see new methods
getting added in the future or do you have other cleanup/changes in mind?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
