xiaohui-sun commented on a change in pull request #4271: Extend Detection Config Validator to validate composite(entity) alerts URL: https://github.com/apache/incubator-pinot/pull/4271#discussion_r290086204
########## File path: thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/detection/validators/entity-pipeline-config-2.yaml ########## @@ -0,0 +1,68 @@ +detectionName: testPipeline +description: My test pipeline +type: COMPOSITE_ALERT Review comment: Actually do we really need to have a "type" here? The type could be inferred from the underline schema. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
