xiaohui-sun commented on a change in pull request #4271: Extend Detection Config Validator to validate composite(entity) alerts URL: https://github.com/apache/incubator-pinot/pull/4271#discussion_r290084049
########## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/validators/DetectionConfigValidator.java ########## @@ -49,12 +50,19 @@ private static final String PROP_DATASET = "dataset"; private static final String PROP_TYPE = "type"; private static final String PROP_RULES = "rules"; + private static final String PROP_ALERTS = "alerts"; private static final String PROP_MERGER = "merger"; private static final String PROP_NAME = "name"; private static final String PROP_DETECTION_NAME = "detectionName"; private static final String PROP_MAX_DURATION = "maxDuration"; private static final String PROP_CLASS_NAME = "className"; + private static final String LEGACY_METRIC_ALERT = "COMPOSITE"; + private static final String METRIC_ALERT = "METRIC_ALERT"; + private static final String COMPOSITE_ALERT = "COMPOSITE_ALERT"; + private static final HashSet<String> SUPPORTED_ALERT_TYPES = new HashSet<>( Review comment: Use Set<String> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
