jasperjiaguo commented on a change in pull request #4270: skip the inverted 
index generation
URL: https://github.com/apache/incubator-pinot/pull/4270#discussion_r291813582
 
 

 ##########
 File path: 
pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/SegmentColumnarIndexCreator.java
 ##########
 @@ -158,7 +158,8 @@ public void init(SegmentGeneratorConfig 
segmentCreationSpec, SegmentIndexCreatio
         }
 
         // Initialize inverted index creator
-        if (invertedIndexColumns.contains(columnName)) {
+        // Skip creating inverted index if sorted; _invertedIndexCreatorMap is 
also correctly populated for metadata writing
 
 Review comment:
   Can you pls merge it? Thx.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to