jasperjiaguo commented on a change in pull request #4270: skip the inverted
index generation
URL: https://github.com/apache/incubator-pinot/pull/4270#discussion_r291814170
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/SegmentColumnarIndexCreator.java
##########
@@ -158,8 +158,12 @@ public void init(SegmentGeneratorConfig
segmentCreationSpec, SegmentIndexCreatio
}
// Initialize inverted index creator
+ // Do not created inverted index if sorted, clean up
invertedIndexColumns
if (invertedIndexColumns.contains(columnName)) {
- if (segmentCreationSpec.isOnHeap()) {
+ if (indexCreationInfo.isSorted()){
+ invertedIndexColumns.remove(columnName);
+ //config.getInvertedIndexCreationColumns().remove(columnName); Do
we clean up config?
Review comment:
I tested the sorted-column + inverted index case and it did skip the
inverted index generation. The HAS_INVERTED_INDEX flag is also good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
