kishoreg commented on a change in pull request #4216: PQL -> SQL enhancement -
phase 1 - new Pinot Query Struct
URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r292735681
##########
File path:
pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/OptionAstNode.java
##########
@@ -54,4 +55,33 @@ public void updateBrokerRequest(BrokerRequest
brokerRequest) {
brokerRequest.getQueryOptions().put(left, right);
}
+
+ @Override
+ public void updatePinotQuery(PinotQuery pinotQuery) {
+ if (getChildren().size() != 2) {
Review comment:
Most of the new code is based on existing code, it's just populating
PinotQuery instead of BrokerRequest. Since we don't have a null check in the
existing code, we don't need one here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
