kishoreg commented on a change in pull request #4216: PQL -> SQL enhancement -
phase 1 - new Pinot Query Struct
URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r292970224
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java
##########
@@ -75,11 +119,9 @@ private static FilterQuery
traverseFilterQueryAndPopulateMap(FilterQueryTree tre
final List<Integer> f = new ArrayList<>();
if (null != tree.getChildren()) {
for (final FilterQueryTree c : tree.getChildren()) {
- int childNodeId = currentId.intValue();
- currentId.increment();
-
- f.add(childNodeId);
final FilterQuery q = traverseFilterQueryAndPopulateMap(c,
filterQueryMap, currentId);
+ int childNodeId = q.getId();
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]