kishoreg commented on a change in pull request #4365: Adding support for 
udf/expression in filter predicates
URL: https://github.com/apache/incubator-pinot/pull/4365#discussion_r298644598
 
 

 ##########
 File path: 
pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/RangelessBitmapDocIdIterator.java
 ##########
 @@ -23,7 +23,7 @@
 import org.roaringbitmap.IntIterator;
 
 
-public class RangelessBitmapDocIdIterator implements BlockDocIdIterator {
+public class RangelessBitmapDocIdIterator implements IndexBasedDocIdIterator {
 
 Review comment:
   thats just a marker interface. It better to mark them as indexBased since it 
has already computed the bitmap otherwise it will be treated as a non-index 
based iterator.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to