kishoreg commented on a change in pull request #4365: Adding support for udf/expression in filter predicates URL: https://github.com/apache/incubator-pinot/pull/4365#discussion_r298645516
########## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/SVScanDocIdIterator.java ########## @@ -34,13 +34,13 @@ private int _startDocId; private int _endDocId; private PredicateEvaluator _evaluator; - private String _datasourceName; + private String _operatorName; private int _numEntriesScanned = 0; private final ValueMatcher _valueMatcher; - public SVScanDocIdIterator(String datasourceName, BlockValSet blockValSet, BlockMetadata blockMetadata, + public SVScanDocIdIterator(String operatorName, BlockValSet blockValSet, BlockMetadata blockMetadata, Review comment: I dont think this toString is used anywhere. Just wanted to remove the reference to datasource as much as possible. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
