buchireddy commented on a change in pull request #4321: #4317 Feature/variable
length bytes offline dictionary for indexing bytes and string dicts.
URL: https://github.com/apache/incubator-pinot/pull/4321#discussion_r299698286
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/HLRealtimeSegmentDataManager.java
##########
@@ -145,6 +146,8 @@ public HLRealtimeSegmentDataManager(final
RealtimeSegmentZKMetadata realtimeSegm
// No DictionaryColumns
noDictionaryColumns = new
ArrayList<>(indexLoadingConfig.getNoDictionaryColumns());
+ varLengthDictionaryColumns = new
ArrayList<>(indexLoadingConfig.getVarLengthDictionaryColumns());
Review comment:
That's because we need the configuration of whether to use a variable length
dictionary for a column when we are converting Realtime segments into Offline
segments. LMK if you know of any better ways of getting this config instead of
carrying in realtime classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
