buchireddy commented on a change in pull request #4321: #4317 Feature/variable
length bytes offline dictionary for indexing bytes and string dicts.
URL: https://github.com/apache/incubator-pinot/pull/4321#discussion_r299713449
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/SegmentDictionaryCreator.java
##########
@@ -211,6 +203,39 @@ public void build()
}
}
+ private void writeBytesValueDictionary(int numValues, byte[][]
sortedByteArrays) throws IOException {
+
+ if (_useVarLengthDictionary) {
Review comment:
Strictly speaking, `VarLengthBytesValueReaderWriter` and
`FixedByteValueReaderWriter` are two implementations of readers but there is no
common `Writer` interface here and hence the way the `byte[]` are written isn't
uniform either.
Like I mentioned in another comment, I'm planning to do another PR to rename
the classes and `ValueReader.java` interface so I'll see if this needs more
cleanup then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
