mayankshriv commented on a change in pull request #4388: Adding support for Map
type fields
URL: https://github.com/apache/incubator-pinot/pull/4388#discussion_r300755669
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/SegmentDictionaryCreator.java
##########
@@ -268,7 +268,7 @@ public int indexOfSV(Object value) {
throw new UnsupportedOperationException("Unsupported data type : " +
_fieldSpec.getDataType());
}
- Arrays.sort(indexes);
+// Arrays.sort(indexes);
Review comment:
Remove instead. Add comment in the PR description of this behavior change.
Perhaps this should be done as a pre-requisite PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
