mayankshriv commented on a change in pull request #4388: Adding support for Map
type fields
URL: https://github.com/apache/incubator-pinot/pull/4388#discussion_r300753959
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/readers/AvroRecordReader.java
##########
@@ -81,8 +82,9 @@ public GenericRow next(GenericRow reuse)
String fieldName = fieldSpec.getName();
Object value = _reusableAvroRecord.get(fieldName);
// Allow default value for non-time columns
+ //Why special treatment for Time Column?
Review comment:
Open an issue so someone can respond to why was time column given special
treatment. Hopefully, they can also add comment in the code explaining the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
