mcvsubbu commented on a change in pull request #4323: [Controller Separation]
Add logic for lead controller resource
URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r304150564
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
##########
@@ -133,6 +134,7 @@ private static long getRandomInitialDelayInSeconds() {
// If it's set to false, existing HLC realtime tables will stop consumption,
and creation of new HLC tables will be disallowed.
// Please make sure there is no HLC table running in the cluster before
disallowing it.
private static final String ALLOW_HLC_TABLES = "controller.allow.hlc.tables";
+ private static final String HELIX_INSTANCE_TYPE =
"controller.helix.instance.type";
Review comment:
let us not use a config to make sure that only controllers register as
participants. Instead, let us have two constructors in
PinotHelixResourceManager: One with (config) and the other with (config,
instanceType). We use the first ctor everywhere except the ControllerStarter.
In the controllerstarter, we can either use the second ctor, or use some static
method like makePnotHelixResoirceManagerForController() and make the second
ctor private.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
