mcvsubbu commented on a change in pull request #4323: [Controller Separation]
Add logic for lead controller resource
URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r304154347
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerStarter.java
##########
@@ -478,9 +475,10 @@ private void stopHelixController() {
private void stopPinotController() {
try {
- // Stopping ControllerLeadershipManager has to be done before stopping
HelixResourceManager.
- LOGGER.info("Stopping controller leadership manager");
- _controllerLeadershipManager.stop();
+ // Stopping periodic tasks has to be done before stopping
HelixResourceManager.
+ // Stop controller periodic task.
+ LOGGER.info("Stopping controller periodic tasks");
Review comment:
We will need to stop lead controller manager so that we stop listening and
reacting to state changes on leader controller resource?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
