mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r304668141
########## File path: pinot-core/src/test/java/org/apache/pinot/server/realtime/ControllerLeaderLocatorTest.java ########## @@ -19,6 +19,7 @@ package org.apache.pinot.server.realtime; import org.apache.helix.BaseDataAccessor; +import org.apache.helix.HelixAdmin; Review comment: Can you please add a test where the resource is disabled, we enable it, and then disable it, and make sure that the right code path s invoked in these cases? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
