jackjlli commented on a change in pull request #4462: Time-aware resizing URL: https://github.com/apache/incubator-pinot/pull/4462#discussion_r306518826
########## File path: pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentPreprocessingJob.java ########## @@ -79,6 +103,7 @@ private final String _defaultPermissionsMask; private TableConfig _tableConfig; + private org.apache.pinot.common.data.Schema _schema; Review comment: Also, since there are two schemas here now, can we rename them, like one called `pinotTableSchema` and the other one called `avroSchema`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
