jackjlli commented on a change in pull request #4462: Time-aware resizing
URL: https://github.com/apache/incubator-pinot/pull/4462#discussion_r307067792
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/name/NormalizedDateSegmentNameGenerator.java
##########
@@ -32,16 +32,20 @@
* Segment name generator that normalizes the date to human readable format.
*/
public class NormalizedDateSegmentNameGenerator implements
SegmentNameGenerator {
- private final String _segmentNamePrefix;
- private final boolean _excludeSequenceId;
- private final boolean _appendPushType;
+ private String _segmentNamePrefix;
+ private boolean _excludeSequenceId;
+ private boolean _appendPushType;
// For APPEND tables
- private final SimpleDateFormat _outputSDF;
+ private SimpleDateFormat _outputSDF;
// For EPOCH time format
- private final TimeUnit _inputTimeUnit;
+ private TimeUnit _inputTimeUnit;
// For SIMPLE_DATE_FORMAT time format
- private final SimpleDateFormat _inputSDF;
+ private SimpleDateFormat _inputSDF;
+
+ public NormalizedDateSegmentNameGenerator(@Nullable String pushFrequency,
@Nullable TimeUnit timeType, @Nullable String timeFormat) {
+ new NormalizedDateSegmentNameGenerator("myTable", null, false, "APPEND",
pushFrequency, timeType, timeFormat);
Review comment:
I still don't like putting a dummy table name to the constructor, can we
check the code to see if table name is needed? Otherwise, we can remove the
annotation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
