jackjlli commented on a change in pull request #4462: Time-aware resizing
URL: https://github.com/apache/incubator-pinot/pull/4462#discussion_r308466269
##########
File path:
pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentPreprocessingJob.java
##########
@@ -218,34 +431,20 @@ private void setMaxNumRecordsConfigIfSpecified(Job job) {
* @return Input schema
* @throws IOException exception when accessing to IO
*/
- private static Schema getSchema(Path inputPathDir)
+ private Schema getSchema(Path inputPathDir)
throws IOException {
FileSystem fs = FileSystem.get(new Configuration());
Schema avroSchema = null;
for (FileStatus fileStatus : fs.listStatus(inputPathDir)) {
if (fileStatus.isFile() &&
fileStatus.getPath().getName().endsWith(".avro")) {
Review comment:
But the schema is fetched from `_dataStreamReader`, which has already been
initialized somewhere else instead of here. `fileStatus` isn't used here at all
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
