jackjlli commented on a change in pull request #4506: Put Helix manager out of
resource manager
URL: https://github.com/apache/incubator-pinot/pull/4506#discussion_r312327336
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -168,8 +168,8 @@ public PinotHelixResourceManager(@Nonnull ControllerConf
controllerConf) {
/**
* Create Helix cluster if needed, and then start a Pinot controller
instance.
*/
- public synchronized void start() {
- _helixZkManager = registerAndConnectAsHelixParticipant();
+ public synchronized void start(HelixManager helixZkManager) {
+ _helixZkManager = helixZkManager;
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
