jackjlli commented on a change in pull request #4506: Put Helix manager out of
resource manager
URL: https://github.com/apache/incubator-pinot/pull/4506#discussion_r312327358
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/perf/PerfBenchmarkDriver.java
##########
@@ -265,11 +271,32 @@ private void startHelixResourceManager()
// Create broker tenant if required
if (_conf.shouldStartBroker()) {
- Tenant brokerTenant = new
TenantBuilder(_brokerTenantName).setRole(TenantRole.BROKER).setTotalInstances(1).build();
+ Tenant brokerTenant =
+ new
TenantBuilder(_brokerTenantName).setRole(TenantRole.BROKER).setTotalInstances(1).build();
_helixResourceManager.createBrokerTenant(brokerTenant);
}
}
+ /**
+ * Register and connect to Helix cluster as Spectator role.
+ */
+ private HelixManager registerAndConnectAsHelixSpectator(ControllerConf
controllerConf) {
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
