kishoreg commented on a change in pull request #4527: Group by with order by
URL: https://github.com/apache/incubator-pinot/pull/4527#discussion_r314147558
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/response/broker/OrderedGroupByResults.java
##########
@@ -28,39 +28,26 @@
/**
* This class holds the results of group by order by query which is set into
the {@link BrokerResponseNative}
*/
-@JsonPropertyOrder({"orderBy", "groupByKeys", "aggregationResults"})
-public class GroupByOrderByResults {
- private List<String> _orderBy;
- private List<String[]> _groupByKeys;
+@JsonPropertyOrder({"groupBy", "aggregationResults"})
+public class OrderedGroupByResults {
Review comment:
Why does it matter if it's ordered or not?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
