kishoreg commented on a change in pull request #4527: Group by with order by URL: https://github.com/apache/incubator-pinot/pull/4527#discussion_r314147427
########## File path: pinot-common/src/main/java/org/apache/pinot/common/response/broker/BrokerResponseNative.java ########## @@ -64,7 +64,7 @@ private SelectionResults _selectionResults; private List<AggregationResult> _aggregationResults; - private GroupByOrderByResults _groupByOrderByResults; + private OrderedGroupByResults _orderedGroupByResults; Review comment: why do we need another element in the response? can we not use the existing structure ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
