mayankshriv commented on a change in pull request #4535: Implement DISTINCT
clause
URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315318434
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/DataBlockCache.java
##########
@@ -366,4 +366,74 @@ public boolean equals(Object obj) {
return _column.equals(that._column) && _dataType == that._dataType;
}
}
+
+ /**
+ * Row Index based APIs for Single Value columns
+ */
+
+ public int getSVIntAtIndex(final String column, final int index) {
Review comment:
It is unclear to me as to why we need to fetch values row-by-row for
distinct, I'd rather avoid exposing this api to avoid function call per row?
Also, there seems to be code duplication, `getSVIntAtIndex` should have just
called `getIntValuesForSVColumn`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
