mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r318277586
########## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/RecordBatch.java ########## @@ -0,0 +1,146 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.query.aggregation; + +import com.google.common.base.Preconditions; +import java.util.Iterator; +import org.apache.pinot.common.data.FieldSpec; +import org.apache.pinot.core.operator.docvalsets.ProjectionBlockValSet; + +/** + * Helper class to iterate over multiple projected columns and build + * rows + */ +public class RecordBatch { Review comment: Seems like we created several new classes to handle distinct e.g. Tuple, TupleHolder, RecordBatch, DistinctResultHolder, etc. While this is a good practice in general, it seems to me that we should have been able to reuse existing classes that are used for other selection/aggr queries to handle DISTINCT as well. Or if the existing ones are not written correctly, then use the new ones in this PR to serve others (in a separate PR). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
