mcvsubbu commented on a change in pull request #4555: [Issue #4551] Remove
memory allocation for virtual columns in consumi…
URL: https://github.com/apache/incubator-pinot/pull/4555#discussion_r317299830
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/IndexSegment.java
##########
@@ -70,16 +70,6 @@
*/
List<StarTreeV2> getStarTrees();
- /**
- * Returns the record for the given document Id.
- * <p>NOTE: don't use this method for high performance code.
- *
- * @param docId Document Id
- * @param reuse Reusable buffer for the record
- * @return Record for the given document Id
- */
- GenericRow getRecord(int docId, GenericRow reuse);
Review comment:
i kept the api the same and filtered out virtual columns from immutable
segments
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
