mcvsubbu commented on a change in pull request #4555: [Issue #4551] Remove memory allocation for virtual columns in consumi… URL: https://github.com/apache/incubator-pinot/pull/4555#discussion_r317333339
########## File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java ########## @@ -95,6 +99,7 @@ private volatile long _minTime = Long.MAX_VALUE; private volatile long _maxTime = Long.MIN_VALUE; private final int _numKeyColumns; + private final Collection<FieldSpec> _physicalColumnFieldSpecs; Review comment: I am not convinced that this is worth the change. In some places we look for fieldspec, and in others the column names. Why don't we get this PR through, and if we find that the 'if' checks are expensive, we can work on other ways to reduce them ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
