siddharthteotia commented on a change in pull request #4535: Implement DISTINCT
clause
URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r318302246
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java
##########
@@ -93,6 +95,8 @@ public static ObjectType getObjectType(Object value) {
return ObjectType.IntSet;
} else if (value instanceof TDigest) {
return ObjectType.TDigest;
+ } else if (value instanceof TupleHolder) {
Review comment:
When I integrate with order by in follow-up PR, I will definitely see if
some of that can be reused. This was specifically written to ser/deser distinct
result as a single aggregation object.
Fixed to use only TupleHolder and removed ServerMultiRowResultSet
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
