siddharthteotia commented on a change in pull request #4535: Implement DISTINCT
clause
URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r319205468
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/AggregationFunction.java
##########
@@ -119,4 +120,6 @@ IntermediateResult merge(@Nonnull IntermediateResult
intermediateResult1,
*/
@Nonnull
FinalResult extractFinalResult(@Nonnull IntermediateResult
intermediateResult);
+
+ void setRecordLimit(int recordLimit, Limits.LimitLevel level);
Review comment:
@mayankshriv , setRecordLimit() API is needed because we need to pass the
upper bounds to restrict memory usage. Using a separate executor will not work
as the bounds work at three different levels -- segment, server and broker.
Executor is only used for the first one. Using the result holder will also not
work for the same reason.
That's why an API was introduced to trickle down this information to the
function since the latter doesn't know if it is being used by the segment,
server or broker.
I suggest we keep this and improvise later if/when there is a better solution
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
