jihaozh commented on a change in pull request #4566: [TE] fix multi-day
granularity alignment issue
URL: https://github.com/apache/incubator-pinot/pull/4566#discussion_r318769655
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionUtils.java
##########
@@ -114,12 +114,6 @@ public static String
getSpecClassName(Class<BaseComponent> componentClass) {
return Collections.emptyList();
}
- df = df.filter(df.getLongs(COL_TIME).between(slice.getStart(),
slice.getEnd())).dropNull(COL_TIME);
Review comment:
This usually caused by the boundary alignment. For example, the detection
window can be 12:00:05-next day 12:00:05 because of the cron schedule delay,
but the data it should look is 12:00:00 - next day 12:00:00. If we add this
filter here, it might filter the anomaly at 12:00:00 today.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
