siddharthteotia commented on a change in pull request #4535: Implement DISTINCT
clause
URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320624501
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/TransformBlockDataFetcher.java
##########
@@ -49,7 +49,32 @@ public TransformBlockDataFetcher(BlockValSet[]
blockValSets, Dictionary[] dictio
return row;
}
- Fetcher createFetcher(BlockValSet blockValSet,
+ /**
+ * Create SV non-dictionary based fetcher
+ * @param blockValSet column value set
+ * @return fetcher
+ */
+ private Fetcher createSVNoDictionaryFetcher(BlockValSet blockValSet) {
+ switch (blockValSet.getValueType()) {
+ case INT:
+ return new SVIntValueFetcher(blockValSet.getIntValuesSV());
+ case LONG:
+ return new SVLongValueFetcher(blockValSet.getLongValuesSV());
+ case FLOAT:
+ return new SVFloatValueFetcher(blockValSet.getFloatValuesSV());
+ case DOUBLE:
+ return new SVDoubleValueFetcher(blockValSet.getDoubleValuesSV());
+ case BOOLEAN:
+ case STRING:
+ return new SVStringValueFetcher(blockValSet.getStringValuesSV());
+ case BYTES:
+ return new SVBytesValueFetcher(blockValSet.getBytesValuesSV());
+ }
+
+ throw new UnsupportedOperationException();
Review comment:
Based on today's discussion and with your new changes, this is not needed
anyway
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
