siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320624937
########## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/FunctionCallAstNode.java ########## @@ -33,6 +36,11 @@ private String _expression; private boolean _isInSelectList; + public static final String DISTINCT_MULTI_COLUMN_SEPARATOR = ":"; + public static final String COLUMN_KEY_IN_AGGREGATION_INFO = "column"; + public static final String COUNT_FUNCTION_NAME = "count"; Review comment: Done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
