mcvsubbu commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324271534
##########
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
##########
@@ -41,20 +43,22 @@
private static ControllerLeaderLocator _instance = null;
public static final Logger LOGGER =
LoggerFactory.getLogger(ControllerLeaderLocator.class);
+ // Minimum millis which must elapse between consecutive invalidation of cache
+ private static final long MILLIS_BETWEEN_INVALIDATE = 30_000;
+
private final HelixManager _helixManager;
- // Co-ordinates of the last known controller leader.
- private Pair<String, Integer> _controllerLeaderHostPort = null;
+ // Co-ordinates of the last known controller leader for every partitions,
with partition name being the key and lead controller info being the value.
Review comment:
```suggestion
// Co-ordinates of the last known controller leader for each of the
lead-controller resource partition,
// with partition number being the key and controller hostname and port
pair being the value. If the lead
// controller resource is disabled in the configuration then this map
contains helix cluster leader co-ordinates
// for all partitions of leadControllerResource
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
