mcvsubbu commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r325371496
##########
File path:
pinot-core/src/test/java/org/apache/pinot/server/realtime/ControllerLeaderLocatorTest.java
##########
@@ -68,45 +69,48 @@ public void testInvalidateCachedControllerLeader() {
// Create Controller Leader Locator
FakeControllerLeaderLocator.create(helixManager);
- ControllerLeaderLocator controllerLeaderLocator =
FakeControllerLeaderLocator.getInstance();
+ FakeControllerLeaderLocator controllerLeaderLocator =
FakeControllerLeaderLocator.getInstance();
// check values at startup
-
Assert.assertTrue(controllerLeaderLocator.isCachedControllerLeaderInvalid());
+
Assert.assertFalse(controllerLeaderLocator.isCachedControllerLeaderValid());
Assert.assertEquals(controllerLeaderLocator.getLastCacheInvalidateMillis(), 0);
// very first invalidate
+ long currentTimeMs = 31_000L;
+ controllerLeaderLocator.setCurrentTimeMs(currentTimeMs);
controllerLeaderLocator.invalidateCachedControllerLeader();
-
Assert.assertTrue(controllerLeaderLocator.isCachedControllerLeaderInvalid());
+
Assert.assertFalse(controllerLeaderLocator.isCachedControllerLeaderValid());
long lastCacheInvalidateMillis =
controllerLeaderLocator.getLastCacheInvalidateMillis();
Assert.assertTrue(lastCacheInvalidateMillis > 0);
+ Assert.assertEquals(lastCacheInvalidateMillis, currentTimeMs);
// invalidate within {@link
ControllerLeaderLocator::getMillisBetweenInvalidate()} millis
// values should remain unchanged
- lastCacheInvalidateMillis = System.currentTimeMillis();
-
controllerLeaderLocator.setLastCacheInvalidateMillis(lastCacheInvalidateMillis);
+ currentTimeMs = 32_000L;
+ controllerLeaderLocator.setCurrentTimeMs(currentTimeMs);
controllerLeaderLocator.invalidateCachedControllerLeader();
-
Assert.assertTrue(controllerLeaderLocator.isCachedControllerLeaderInvalid());
+
Assert.assertFalse(controllerLeaderLocator.isCachedControllerLeaderValid());
Assert.assertEquals(controllerLeaderLocator.getLastCacheInvalidateMillis(),
lastCacheInvalidateMillis);
// getControllerLeader, which validates the cache
controllerLeaderLocator.getControllerLeader(testTable);
-
Assert.assertFalse(controllerLeaderLocator.isCachedControllerLeaderInvalid());
+ Assert.assertTrue(controllerLeaderLocator.isCachedControllerLeaderValid());
Assert.assertEquals(controllerLeaderLocator.getLastCacheInvalidateMillis(),
lastCacheInvalidateMillis);
// invalidate within {@link
ControllerLeaderLocator::getMillisBetweenInvalidate()} millis
// values should remain unchanged
- lastCacheInvalidateMillis = System.currentTimeMillis();
-
controllerLeaderLocator.setLastCacheInvalidateMillis(lastCacheInvalidateMillis);
+ currentTimeMs = 33_000L;
+ controllerLeaderLocator.setCurrentTimeMs(currentTimeMs);
controllerLeaderLocator.invalidateCachedControllerLeader();
-
Assert.assertFalse(controllerLeaderLocator.isCachedControllerLeaderInvalid());
-
Assert.assertEquals(controllerLeaderLocator.getLastCacheInvalidateMillis(),
lastCacheInvalidateMillis);
+ Assert.assertTrue(controllerLeaderLocator.isCachedControllerLeaderValid());
+ Assert.assertTrue(controllerLeaderLocator.getLastCacheInvalidateMillis() <
currentTimeMs);
Review comment:
You don't need line 106 now :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
