kishoreg commented on a change in pull request #4602: First pass of GROUP BY
with ORDER BY support
URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324411811
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/plan/CombinePlanNode.java
##########
@@ -141,6 +146,12 @@ public Operator run() {
// TODO: use the same combine operator for both aggregation and selection
query.
if (_brokerRequest.isSetAggregationsInfo() && _brokerRequest.getGroupBy()
!= null) {
// Aggregation group-by query
+ Map<String, String> queryOptions = _brokerRequest.getQueryOptions();
+ // new Combine operator only when GROUP_BY_MODE explicitly set to SQL
+ if (queryOptions != null &&
SQL.equals(queryOptions.get(QueryOptionKey.GROUP_BY_MODE))) {
Review comment:
case insensitive check?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
