kishoreg commented on a change in pull request #4602: First pass of GROUP BY
with ORDER BY support
URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324411231
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -224,13 +221,19 @@ public BrokerResponse handleRequest(JsonNode request,
@Nullable RequesterIdentit
LOGGER.debug("Enable trace for request {}: {}", requestId, query);
brokerRequest.setEnableTrace(true);
}
+
if (request.has(DEBUG_OPTIONS)) {
- Map<String, String> debugOptions =
Splitter.on(';').omitEmptyStrings().trimResults().withKeyValueSeparator('=')
- .split(request.get(DEBUG_OPTIONS).asText());
+ Map<String, String> debugOptions = getOptionsFromRequest(request,
DEBUG_OPTIONS);
LOGGER.debug("Debug options are set to: {} for request {}: {}",
debugOptions, requestId, query);
brokerRequest.setDebugOptions(debugOptions);
}
+ if (request.has(QUERY_OPTIONS)) {
Review comment:
Is this the only place we are reading query options?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
