mcvsubbu commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r325378284
##########
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
##########
@@ -181,6 +181,7 @@ private void
refreshControllerLeaderMapFromHelixClusterLeader() {
try {
Pair<String, Integer> helixClusterLeader = getHelixClusterLeader();
if (helixClusterLeader == null) {
+ LOGGER.error("Failed to refresh the controller leader map.");
Review comment:
you are right, there is only one failure mode, so let us leave it as it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
