somandal commented on code in PR #15330:
URL: https://github.com/apache/pinot/pull/15330#discussion_r2006524801
##########
docker/images/pinot/etc/jmx_prometheus_javaagent/configs/controller.yml:
##########
@@ -48,6 +48,21 @@ rules:
table: "$2$4"
tableType: "$5"
taskType: "$6"
+ # Special handling for timers like cronSchedulerJobExecutionTimeMs and
tableRebalanceExecutionTimeMs
Review Comment:
I don't know if this is better, but I can probably combine both into a
single regex, and just use `taskType` for both:
```
# Special handling for timers like cronSchedulerJobExecutionTimeMs and
tableRebalanceExecutionTimeMs
- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.(([^.]+)\\.)?([^.]*)\\.(\\w+)\\.(tableRebalanceExecutionTimeMs|cronSchedulerJobExecutionTimeMs)\"><>(\\w+)"
name: "pinot_controller_$5_$6"
cache: true
labels:
database: "$2"
table: "$1$3"
taskType: "$4"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
