suddendust commented on code in PR #15330:
URL: https://github.com/apache/pinot/pull/15330#discussion_r2006887838
##########
docker/images/pinot/etc/jmx_prometheus_javaagent/configs/controller.yml:
##########
@@ -48,6 +48,21 @@ rules:
table: "$2$4"
tableType: "$5"
taskType: "$6"
+ # Special handling for timers like cronSchedulerJobExecutionTimeMs and
tableRebalanceExecutionTimeMs
Review Comment:
We can do that but I think that'll not be idiomatic for
`tableRebalanceExecutionTimeMs` (`taskType=DONE` doesn't make much sense). I
think we can stick to two regexps. cc @Jackie-Jiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
