npawar commented on a change in pull request #4602: First pass of GROUP BY with
ORDER BY support
URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r327250217
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/query/AggregationGroupByOperator.java
##########
@@ -58,6 +64,34 @@ public AggregationGroupByOperator(@Nonnull
AggregationFunctionContext[] function
_transformOperator = transformOperator;
_numTotalRawDocs = numTotalRawDocs;
_useStarTree = useStarTree;
+
+ int numColumns = groupBy.getExpressionsSize() + _functionContexts.length;
Review comment:
I personally feel this much change is fine. If you/everyone feel strongly
about not touching existing path, I'll separate it out
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
