npawar commented on a change in pull request #4602: First pass of GROUP BY with
ORDER BY support
URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r330841004
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/data/table/Table.java
##########
@@ -37,9 +37,10 @@
* @param aggregationInfos the aggregation info for the values if applicable
* @param orderBy the order by information if applicable
* @param maxCapacity the max capacity the table should have
+ * @param sort should the results be sorted in finish
*/
void init(@Nonnull DataSchema dataSchema, List<AggregationInfo>
aggregationInfos, List<SelectionSort> orderBy,
- int maxCapacity);
+ int maxCapacity, boolean sort);
Review comment:
addressed above. sort flag is needed in iterator and in finish.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
