somandal commented on code in PR #15330:
URL: https://github.com/apache/pinot/pull/15330#discussion_r2014826546


##########
docker/images/pinot/etc/jmx_prometheus_javaagent/configs/controller.yml:
##########
@@ -48,6 +48,21 @@ rules:
     table: "$2$4"
     tableType: "$5"
     taskType: "$6"
+  # Special handling for timers like cronSchedulerJobExecutionTimeMs and 
tableRebalanceExecutionTimeMs

Review Comment:
   @Jackie-Jiang I have updated the regex to extract `tableType` separately 
from the `table` name as discussed, and updated tests accordingly. Please take 
a look when you get a chance.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to